Skip to content
This repository has been archived by the owner on Oct 13, 2024. It is now read-only.

fix: modify updateProgress function to handle timeout issues #334

Merged
merged 1 commit into from
May 18, 2024
Merged

fix: modify updateProgress function to handle timeout issues #334

merged 1 commit into from
May 18, 2024
+223 −154

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented May 18, 2024 •
edited
Loading

Description

Logic needs to be modified to handle longer timeouts.

Todo:

  • possibly page through items instead of getting all items in a single request
  • possibly cache data like we do for the Plex plugin

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@codecov Codecov
Copy link

codecov bot commented May 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.97%. Comparing base (9d2e3e1) to head (290cf43).
Report is 64 commits behind head on master.

Files Patch % Lines
Jellyfin.Plugin.Themerr/Api/ThemerrController.cs 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #334      +/-   ##
==========================================
+ Coverage   69.15%   69.97%   +0.81%     
==========================================
  Files           5        5              
  Lines         415      413       -2     
  Branches       37       36       -1     
==========================================
+ Hits          287      289       +2     
+ Misses        115      112       -3     
+ Partials       13       12       -1
Files Coverage Δ
Jellyfin.Plugin.Themerr/Api/ThemerrController.cs 61.85% <83.33%> (+3.26%) ⬆️

@ReenigneArcher ReenigneArcher force-pushed the fix-modify-updateProgress-function-to-handle-timeout-issues branch 3 times, most recently from 798afff to 7866f10 Compare May 18, 2024 16:37
@ReenigneArcher ReenigneArcher force-pushed the fix-modify-updateProgress-function-to-handle-timeout-issues branch from 7866f10 to 290cf43 Compare May 18, 2024 17:11
@ReenigneArcher ReenigneArcher marked this pull request as ready for review May 18, 2024 17:13
@ReenigneArcher ReenigneArcher merged commit 842105b into master May 18, 2024
17 checks passed
@ReenigneArcher ReenigneArcher deleted the fix-modify-updateProgress-function-to-handle-timeout-issues branch May 18, 2024 18:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request timed out when calling /Themerr/GetProgress
1 participant
@ReenigneArcher